milvus: Avoid crashing when empty documents are supplied to AddDocuments #959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.Explanation
When interacting with different ways to create documents and then proceeding to AddDocuments, sometimes you can create an empty list of documents. This currently generates a crash due to line 211 of
milvus.go
. Other vectorstores (like chroma's) do not have this restriction, and there is no clear assumption that the documents have to be nonempty in the interface.This PR makes AddDocuments a noop when empty documents are passed into it.